-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support flat config for eslint-config-airbnb-base
#3061
base: master
Are you sure you want to change the base?
Conversation
eslint-config-airbnb-base
c13cacf
to
b546a7e
Compare
Is this pull request fully functional? only approval is missing? |
@mcorbelli no, it’s not functional until eslint-find-rules is updated. |
@ljharb FYI: eslint-find-rules does have flat-config support now: https://github.com/sarbbottam/eslint-find-rules/releases/tag/v4.2.0 |
Thanks, I’m aware since I’m the one who published it :-) |
@@ -87,6 +88,7 @@ | |||
"node": "^10.12.0 || >=12.0.0" | |||
}, | |||
"dependencies": { | |||
"confusing-browser-globals": "^1.0.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this PR is to ensure compatibility between eslint-config-airbnb-base and ESLint 9, correct? It looks like you'll need to update line 83 to include ESLint 9 as a peer dependency.
This pull request supports flat config for
eslint-config-airbnb-base
.An example of usage is as follows.