Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov upload #73

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix codecov upload #73

merged 1 commit into from
Dec 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 1, 2024

The old token was still pointing to https://app.codecov.io/github/Bluetooth-Devices/propcache

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Dec 1, 2024
Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #73 will not alter performance

Comparing fix_codecov_upload (ab09a51) with master (2514c3f)

Summary

✅ 4 untouched benchmarks

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (75e3cd2) to head (ab09a51).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   88.90%   89.02%   +0.12%     
==========================================
  Files          18       18              
  Lines         721      738      +17     
  Branches       73       75       +2     
==========================================
+ Hits          641      657      +16     
- Misses         62       63       +1     
  Partials       18       18              
Flag Coverage Δ
CI-GHA 89.02% <ø> (+0.12%) ⬆️
MyPy 78.49% <ø> (+1.13%) ⬆️
OS-Linux 99.44% <ø> (+0.02%) ⬆️
OS-Windows 95.41% <ø> (+0.25%) ⬆️
OS-macOS 95.86% <ø> (+0.20%) ⬆️
Py-3.10.11 95.59% <ø> (+0.21%) ⬆️
Py-3.10.15 97.79% <ø> (+0.10%) ⬆️
Py-3.11.10 97.79% <ø> (+0.10%) ⬆️
Py-3.11.9 95.59% <ø> (+0.21%) ⬆️
Py-3.12.7 97.79% <ø> (+0.10%) ⬆️
Py-3.13.0 97.79% <ø> (+0.10%) ⬆️
Py-3.9.13 95.58% <ø> (+0.21%) ⬆️
Py-3.9.20 97.79% <ø> (+0.10%) ⬆️
Py-pypy7.3.16 97.23% <ø> (+0.15%) ⬆️
Py-pypy7.3.17 97.24% <ø> (+0.15%) ⬆️
VM-macos-latest 95.86% <ø> (+0.20%) ⬆️
VM-ubuntu-latest 99.44% <ø> (+0.02%) ⬆️
VM-windows-latest 95.41% <ø> (+0.25%) ⬆️
pytest 99.44% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review December 1, 2024 16:00
@bdraco bdraco merged commit 4c94388 into master Dec 1, 2024
47 checks passed
@bdraco bdraco deleted the fix_codecov_upload branch December 1, 2024 16:00
@webknjaz
Copy link
Member

webknjaz commented Dec 1, 2024

Are you sure? I was convinced I took it from the right place...
b845a6e

@bdraco
Copy link
Member Author

bdraco commented Dec 1, 2024

@webknjaz
Copy link
Member

webknjaz commented Dec 1, 2024

Oh wow, how did I miss that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants