-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code indent in ResponseHandler.data_received #8699
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #8699 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 107 107
Lines 34699 34700 +1
Branches 4111 4111
=======================================
+ Hits 34152 34153 +1
Misses 380 380
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks like we are missing coverage for |
I feel like that relates to #8597 (comment) or one of my other parser changes. I'm not really sure if it's still possible to reach that code at all... |
I'll dig through the code paths this weekend if flights cooperate. |
Looks like websocket will never have a tail unless there is an exception |
I spent a few hours digging at it, and I can't find a case or make a case where |
Then I reckon remove it, but also skip the 3.10 backport as a precaution. |
be5c09f
to
d586152
Compare
Still having trouble getting comfortable with removing that code, need to spend a few more hours tracing |
What do these changes do?
Code cleanup only, no functional change
There were some else after returns that could be converted to guards to reduce code indent.
While looking at the full WebSockets path for #8258 I noticed this could be improved a bit
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no