Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split function body application from name in some cases #1083

Merged
merged 12 commits into from
Jan 12, 2025
Merged

Split function body application from name in some cases #1083

merged 12 commits into from
Jan 12, 2025

Conversation

MicroProofs
Copy link
Member

@MicroProofs MicroProofs commented Jan 11, 2025 •
edited
Loading 

The ultimate function when used in conjunction with case_constr_apply
This splits [lam fun_name [lam fun_name2 rest ..] ..] into
[[lam fun_name lam fun_name2 rest ..]..] thus
 allowing for some crazy gains from cast_constr_apply_reducer

@MicroProofs MicroProofs requested a review from a team as a code owner January 11, 2025 10:37
@MicroProofs
Copy link
Member Author

Merge after the write bits pr to make the diff much smaller.

MicroProofs
MicroProofs commented Jan 11, 2025
View reviewed changes
crates/aiken-project/src/snapshots/aiken_project__export__tests__basic_export.snap
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same size simply different ordering of lambda applications

@MicroProofs
Inline now handles (if cond then body else error) patterns.
19b4b9d 
This allows conditions like ```expect x == 1``` to match performance with ```x == 1 && ...```

Also change builtins forcing to accommodate the new case-constr apply optimization
@MicroProofs
Remove some prints and switch an uneeded isize to usize since it can'…
c1ed0dc 
…t be negative
@MicroProofs
Add case constr for applies greater than 2 optimization
33392f1
@MicroProofs
Make sure clean up doesn't add case and constr to comp time eval. Als…
2c21418 
…o had fun with test_1 mint script context validator
@MicroProofs
DecodeUtf8 is not error safe
7462f1d
@MicroProofs
Oops did wrong comparison check on number of consecutive applies
19d0ec2
@MicroProofs
Add writeBits back in and use the optimizer to utilize the list conve…
f7f68fb 
…rsion
@MicroProofs
Conformance tests should be using NamedDebruijn comparisons not name.…
a3a3185 
… Also no inline remover needs to run separately from other uplc transformations
@MicroProofs
Clippy fix
e437d70
@MicroProofs
Handle case where write_bits is used without being applied
d559e38
@MicroProofs
New optimization to split independent lam function applications to en…
09ddec6 
…able case constr to optimize further
@MicroProofs MicroProofs merged commit 6d2e388 into main Jan 12, 2025
13 checks passed
@MicroProofs MicroProofs deleted the funtion_body_split branch January 12, 2025 09:45
KtorZ
KtorZ reviewed Jan 16, 2025
View reviewed changes
examples/acceptance_tests/script_context/v3/validators/mint.ak
@@ -83,6 +83,8 @@ fn assert_outputs(
},
) == list.at(outputs, 0)

trace @"This test validator has a higher hash than the one below. Change and try again."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ left review comments

Assignees
No one assigned
Labels
None yet
Projects
Project Tracking
Status: ✅ In Next Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicroProofs @KtorZ