Allow write_bits builtin and add a few more optimizations #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroProofs
force-pushed
the
write-bits-plus-other-optimize
branch
from
9257f9e to
c44d9a1
Compare
KtorZ
reviewed
Jan 9, 2025
crates/uplc/src/optimize/shrinker.rs
Outdated
| | DefaultFunction::AppendByteString | ||
| | DefaultFunction::LessThanEqualsByteString | ||
| | DefaultFunction::LessThanByteString => arg_stack.iter().all(|arg| { | ||
| | DefaultFunction::LessThanByteString | ||
| | DefaultFunction::DecodeUtf8 |
There was a problem hiding this comment.
I don't believe this is generally true? Decoding an invalid bytestring will throw / error. Though maybe I am misunderstanding this function (does it only look at arguments?)
There was a problem hiding this comment.
Oh you are right. I'll remove it.
|
Will merge tomorrow unless anything else is needed. |
This allows conditions like ```expect x == 1``` to match performance with ```x == 1 && ...``` Also change builtins forcing to accommodate the new case-constr apply optimization
…o had fun with test_1 mint script context validator
… Also no inline remover needs to run separately from other uplc transformations
MicroProofs
force-pushed
the
write-bits-plus-other-optimize
branch
from
90fa7f6 to
d559e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.