-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update chang#2 costmodels #1058
Conversation
b5ee5aa
to
55c6907
Compare
}, | ||
ripemd_160: CostingFun { | ||
cpu: OneArgument::ConstantCost(30000000000), | ||
mem: OneArgument::ConstantCost(30000000000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure that these builtins will be retro-actively added to PlutusV2 as well (not sure about V1 🤔). So the cost model for v2 also need to cover for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @hadelive! Note that we also need to update the underlying VM to recognize and implement those new builtins; but that PR definitely reduces the size of the work 🙏
QQ: Without these changes the Cardano Preprod network is essentially unable to be used with Aiken? Without somehow changing the Cost Models retrieved from the network Providers. Would it be safe to "drop" the last lot of Parameters? Or perhaps in the interim change the Assert to expect the correct number of parameters? (I'm really sorry if this comment comes off a little off, I've been trying to work out why my contracts just did not work in Preprod and didn't understand until I found this PR!!) |
See the other PR that is a WIP |
Aiken's contract are fine on preprod; what isn't is the surrounding tooling for, e.g. simulating transactions. So the issue is with the rust implementation of the virtual machine; not the language itself (although the new builtins needs to be made available to the language as well; but that doesn't impact existing contracts). |
Closed by #1064 |
No description provided.