Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update chang#2 costmodels #1058

Closed
wants to merge 1 commit into from

Conversation

hadelive
Copy link
Contributor

No description provided.

@hadelive hadelive requested a review from a team as a code owner November 19, 2024 05:26
@hadelive hadelive changed the title feat: update change#2 costmodels feat: update chang#2 costmodels Nov 19, 2024
},
ripemd_160: CostingFun {
cpu: OneArgument::ConstantCost(30000000000),
mem: OneArgument::ConstantCost(30000000000),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that these builtins will be retro-actively added to PlutusV2 as well (not sure about V1 🤔). So the cost model for v2 also need to cover for them.

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @hadelive! Note that we also need to update the underlying VM to recognize and implement those new builtins; but that PR definitely reduces the size of the work 🙏

@gavinharris-dev
Copy link

QQ: Without these changes the Cardano Preprod network is essentially unable to be used with Aiken? Without somehow changing the Cost Models retrieved from the network Providers. Would it be safe to "drop" the last lot of Parameters? Or perhaps in the interim change the Assert to expect the correct number of parameters?

(I'm really sorry if this comment comes off a little off, I've been trying to work out why my contracts just did not work in Preprod and didn't understand until I found this PR!!)

@MicroProofs
Copy link
Member

See the other PR that is a WIP

@KtorZ
Copy link
Member

KtorZ commented Dec 3, 2024

QQ: Without these changes the Cardano Preprod network is essentially unable to be used with Aiken? Without somehow changing the Cost Models retrieved from the network Providers. Would it be safe to "drop" the last lot of Parameters? Or perhaps in the interim change the Assert to expect the correct number of parameters?

(I'm really sorry if this comment comes off a little off, I've been trying to work out why my contracts just did not work in Preprod and didn't understand until I found this PR!!)

Aiken's contract are fine on preprod; what isn't is the surrounding tooling for, e.g. simulating transactions.

So the issue is with the rust implementation of the virtual machine; not the language itself (although the new builtins needs to be made available to the language as well; but that doesn't impact existing contracts).

@MicroProofs
Copy link
Member

Closed by #1064

@MicroProofs MicroProofs closed this Dec 7, 2024
@hadelive hadelive deleted the chang2-costmodels branch December 7, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ In Next Release
Development

Successfully merging this pull request may close these issues.

4 participants