Use a decision tree for when Expressions #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroProofs
force-pushed
the
decision-trees
branch
from
995a1ca to
edcb53b
Compare
MicroProofs
force-pushed
the
decision-trees
branch
from
d42c3e7 to
0a51016
Compare
… paper handles wild card patterns
…h DecisionTree switch case
…nish unit tests and add a few more
MicroProofs
force-pushed
the
decision-trees
branch
from
6b57332 to
362eb75
Compare
|
Closes #887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the algorithm from this paper
https://www.cs.tufts.edu/comp/150FP/archive/luc-maranget/jun08.pdf
We can make the pattern matching when expressions in Aiken both more efficient and simpler in codegen. Instead of processing a TypedExpr of cases and nested cases. We instead build up a decision tree and use that to produce the Air op codes to carry out the pattern matching. Which enables a large simplification to the existing op codes today.
For another in depth explanation and implementation of the algorithm described above. Look here
https://github.com/clojure/core.match/wiki/Understanding-the-algorithm