feat: [Issue-185] Token Provider Tests #365
Open
+15,433
−12,234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@ponderingdemocritus This is based on your earlier instructions to include and use vitest: |
ponderingdemocritus
changed the title
packages/adapter-sqlite/package.json
Outdated
| }, | ||
| "exports": { | ||
| ".": "./dist/index.js", | ||
| "./sqlite_vec": "./dist/sqlite_vec.js" |
There was a problem hiding this comment.
i don't think this is needed - exported at index
packages/plugin-solana/src/index.ts
Outdated
| import { Connection } from "@solana/web3.js"; | ||
| import { PublicKey } from "@solana/web3.js"; | ||
|
|
||
| export { TokenProvider, WalletProvider, Connection, PublicKey }; |
There was a problem hiding this comment.
remove the solana exports and import where needed from the packages
There was a problem hiding this comment.
Good catch, this was left over from another test I was working on, but ended up simplifying for this first PR
|
@ponderingdemocritus Thanks for the feedback! Just pushed an update based on comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#185
Risks
Low: Only modification to src code files was adding optional syntax an
Background
What does this PR do?
packages/core/src/tests/token.test.tsWhat kind of change is this?
Improvements - Tests
See Issue above
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
pnpm -w run test -- 'src/tests/token.test.ts'Where should a reviewer start?
Detailed testing steps