Feature/remove default arguments warning for volume extension (osrf#292)

* add: type hints for parser argument --------- Co-authored-by: Tully Foote <[email protected]>
agyoungs · Oct 16, 2024 · 3c9ea15 · 3c9ea15
1 parent 3f02bdc
commit 3c9ea15
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/rocker/volume_extension.py b/src/rocker/volume_extension.py
@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from argparse import ArgumentParser
 from argparse import ArgumentTypeError
 import os
 from rocker.extensions import RockerExtension
@@ -61,7 +62,7 @@ def get_docker_args(self, cli_args):
         return ' '.join(args)
 
     @staticmethod
-    def register_arguments(parser, defaults):
+    def register_arguments(parser: ArgumentParser, defaults: dict):
         parser.add_argument(Volume.ARG_ROCKER_VOLUME,
             metavar='HOST-DIR[:CONTAINER-DIR[:OPTIONS]]',
             type=str,