-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd jobstore support for apscheduler 3.x #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't have entertained the idea of adding a new back-end to the 3.x series but this PR was exceptionally well prepared, so I'm giving it a pass. I left some minor comments which should be addressed before merging though.
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Hi agronholm! Thank you very much for your review of my code and your valuable suggestions, I made some changes to them. |
There seems to be a problem in executor. This should not be caused by the new back-end. Could you help to take a look? |
|
OK, thank you! I have no other questions. |
Recently, many people use etcd as their metadata hub, so I tried adding etcd persistent job storage for Apscheduler 3.x. I added the corresponding unit tests with 100% coverage, and they passed the tests locally.