psplash: udev rule to notify systemd of available framebuffers #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up of #1261 based on a new branch |
kraj
reviewed
Jan 26, 2024
Kiwi4Inovex
force-pushed
the
fix_psplash_timeout
branch
2 times, most recently
from
2b0742f
to
5b3280a
Compare
agherzan
reviewed
Feb 1, 2024
Kiwi4Inovex
force-pushed
the
fix_psplash_timeout
branch
from
5b3280a
to
82af6ff
Compare
kraj
approved these changes
May 21, 2024
|
@Kiwi4Inovex can you rebase your branch on top of latest master and push this again so we can merge it with clean history. |
Kiwi4Inovex
force-pushed
the
fix_psplash_timeout
branch
3 times, most recently
from
955d63c
to
46efc9e
Compare
agherzan
requested changes
Jun 3, 2024
|
Also, could you please look into the branch conflict with master? |
Kiwi4Inovex
force-pushed
the
fix_psplash_timeout
branch
2 times, most recently
from
bbb2f50
to
7252172
Compare
agherzan
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Thanks again for this. Could you tweak your commit message to be in accordance with our contribution guidelines? You can find them here (https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html), and you can also see examples in the history. In this specific case, there si no SoB footer.
|
Another small comment: you are changing the "udev-rules-rpi" recipe, so I would use that in the subject line. |
Kiwi4Inovex
force-pushed
the
fix_psplash_timeout
branch
from
7252172
to
055bfa4
Compare
Add udev rule to notify systemd of available framebuffer Using psplash in combination with systemd the splash screen is not shown. The dependency to sys-devices-platform-gpu-graphics-fb0.device will terminate psplash-start.service because systemd is not aware of the existing framebuffer device node. See https://lists.yoctoproject.org/g/yocto/topic/91286438#57156 Signed-off-by: Bastian Wanner <[email protected]>
Kiwi4Inovex
force-pushed
the
fix_psplash_timeout
branch
from
055bfa4
to
5ebc69d
Compare
|
Took me awhile sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using psplash in combination with systemd the splash screen is not shown. The dependency to sys-devices-platform-gpu-graphics-fb0.device will terminate psplash-start.service because systemd is not aware of the framebuffer device node.
See https://lists.yoctoproject.org/g/yocto/topic/91286438#57156
Adding a udev rule to notify systemd