-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Raspberry Pi Camera Module v3 to Kirkstone #1172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It seems the build has run into the issue mentioned by @quaresmajose on #1158. Probably because the imx708 drivers are missing from kernel versions < 5.15.84. |
The most reasonable thing to do IMO is backporting the imx708 on the kernel 5.10 but please note that it build but doesn't work on this kernel so maybe a note will be needed about that. |
Is it necessary for both kernel version 5.10 and 5.15 to be supported on the Kirkstone branch, as 5.10 is also on Holister, Hardknott and Gatesgarth? It appears that the differences between 5.10 and 5.15 are significant enough that maybe they should not be supported at the same time. This way there is no need for backporting any drivers. |
@agherzan what are your thoughts on this? |
@quaresmajose That would be just masking an issue. So I'm not sure if I'm on board with that. |
Head branch was pushed to by a user without write access
Pull request was closed
3bb0446
to
43683cb
Compare
I accidentally reset the source branch of this PR, but I will try to make a separate layer. Closing this PR for now. |
@floion is requesting at meta-balena for the changes of #1158 to be applied to meta-raspberrypi/kirkstone as well.