Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Raspberry Pi Camera Module v3 to Kirkstone #1172

Closed
wants to merge 0 commits into from

Conversation

Jessseee
Copy link
Contributor

@floion is requesting at meta-balena for the changes of #1158 to be applied to meta-raspberrypi/kirkstone as well.

Copy link
Owner

@agherzan agherzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@agherzan agherzan enabled auto-merge (rebase) April 30, 2023 08:49
@Jessseee
Copy link
Contributor Author

Jessseee commented Apr 30, 2023

It seems the build has run into the issue mentioned by @quaresmajose on #1158. Probably because the imx708 drivers are missing from kernel versions < 5.15.84.

@quaresmajose
Copy link
Contributor

The most reasonable thing to do IMO is backporting the imx708 on the kernel 5.10 but please note that it build but doesn't work on this kernel so maybe a note will be needed about that.
In this way kernel 5.10 still be usable and the camera could be used on the 5.15.

@Jessseee
Copy link
Contributor Author

Jessseee commented May 2, 2023

Is it necessary for both kernel version 5.10 and 5.15 to be supported on the Kirkstone branch, as 5.10 is also on Holister, Hardknott and Gatesgarth? It appears that the differences between 5.10 and 5.15 are significant enough that maybe they should not be supported at the same time. This way there is no need for backporting any drivers.

@Jessseee
Copy link
Contributor Author

Jessseee commented May 8, 2023

@agherzan what are your thoughts on this?

@agherzan
Copy link
Owner

@quaresmajose That would be just masking an issue. So I'm not sure if I'm on board with that.
@Jessseee The only clean way I see is to keep the change in master and backport the change on kirkstone in a separate layer. And master to drop 5.10.

auto-merge was automatically disabled June 29, 2023 06:31

Head branch was pushed to by a user without write access

@Jessseee Jessseee closed this Jun 29, 2023
auto-merge was automatically disabled June 29, 2023 06:31

Pull request was closed

@Jessseee Jessseee force-pushed the kirkstone branch 2 times, most recently from 3bb0446 to 43683cb Compare June 29, 2023 06:31
@Jessseee
Copy link
Contributor Author

Jessseee commented Jun 29, 2023

I accidentally reset the source branch of this PR, but I will try to make a separate layer. Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants