Use material design list formatting for session and project lists #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.google.com/design/spec/components/lists.html session/project lists are expandable lists, the material/paper formatting doesn't work right in this context. Instead use the behaviour recommended for lists with expandable content: - No elevation shadows or extra margins - Style like a flat list of items - When an item is expanded show a divider appears above and below the item
|
Thanks @dantman for the PR. I can't judge this right away due to lack of Material Design knowledge. Give me some time then I will get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.google.com/design/spec/components/lists.html
session/project lists are expandable lists, the material/paper formatting doesn't work right in this context.
Instead use the behaviour recommended for lists with expandable content: