feat(web): Migration to PatternFly v6, round 4 #1961
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing it with a plain <b> by now. Components using it are gonna be refactored anyway.
In small pieces to make it easier to read, mantain, and to stop using nested functions that are re-created in each render.
Because the "card field" approach does not scale as desired and results a bit confusing.
For stop using Page.Section#value due that the "card field" approach does not scale as desired and results a bit confusing.
From ChangeProductLink to ChangeProductOption
No longer needed after stop using the "card field" approach in the rest of components. It was a bit confusing and didn't scale as desired.
Replacing it with a Page.Section component by now. Perphap PatternFly introduces the fielsdet in a future, see patternfly/patternfly#4893 (comment)
dgdavid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #1900 and #1921, and #1954