Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): use "dashed" form for systemd-firstboot keymap #1952

Open
wants to merge 2 commits into
base: fix-scripts-reader
Choose a base branch
from

Conversation

imobachgs
Copy link
Contributor

Problem

When writing the keymap to be used by the target system, Agama does not uses the "dashed" form:
"es(ast)" instead of es-ast.

Solution

Use the "dashed" form in that case so systemd-firstboot is able to handle the keyboard.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss a unit test, but not sure how you're doing that in Rust.

Code LGTM anyway.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13005419087

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-18.2%) to 70.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/l10n/model.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 12995156707: -18.2%
Covered Lines: 17299
Relevant Lines: 24388

💛 - Coveralls

@imobachgs
Copy link
Contributor Author

In this case what I really miss is an integration test to be sure that everything is set up as expected after the first boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants