fixed bug in percentage calculation

afsc-gap-products · Oct 18, 2024 · 271d98e · 271d98e
1 parent 0d0fc3c
commit 271d98e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/functions/calc_diff.R b/functions/calc_diff.R
@@ -11,11 +11,11 @@ calc_diff <- function(v1, v2, percent = T) {
 
   df <- data.table::data.table("v1" = v1, 
                                "v2" = v2,
-                               "DIFF" = v1 - v2)
+                               "DIFF" = v2 - v1)
   data.table::setnames(x = df, c("v1", "v2", "DIFF"))
 
   df[, v2 := ifelse(test = v2 == 0, 1, v2)]
-  df[, PERC_DIFF := DIFF / v2]
+  df[, PERC_DIFF := 100 * DIFF / v1]
 
   return(df[, ifelse(percent == T, "PERC_DIFF", "DIFF"), with = F])
 }