refactor: consistent error handling

aeternity · Jul 7, 2021 · d77ddfd · d77ddfd
1 parent 22d8324
commit d77ddfd
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/src/components/ListOfTipsAndComments.vue b/src/components/ListOfTipsAndComments.vue
@@ -143,7 +143,7 @@ export default {
         this.error = false;
       } catch (error) {
         this.error = true;
-        throw error;
+        console.error(error);
       } finally {
         this.showLoading = false;
       }

diff --git a/src/components/SendComment.vue b/src/components/SendComment.vue
@@ -15,7 +15,6 @@
 </template>
 
 <script>
-import { handleUnknownError } from '../utils';
 import MessageInput from './MessageInput.vue';
 
 export default {
@@ -43,8 +42,8 @@ export default {
           { text: this.comment, tipId: this.tipId, parentId: this.parentId },
         );
         this.comment = '';
-      } catch (e) {
-        if (e.message !== 'Operation rejected by user') handleUnknownError(e);
+      } catch (error) {
+        if (error.message !== 'Operation rejected by user') throw error;
       } finally {
         this.loading = false;
       }

diff --git a/src/components/TipInput.vue b/src/components/TipInput.vue
@@ -221,7 +221,7 @@ export default {
         this.hideModal();
       } catch (error) {
         this.error = true;
-        throw error;
+        console.error(error);
       } finally {
         this.showLoading = false;
       }

diff --git a/src/components/UserInfo.vue b/src/components/UserInfo.vue
@@ -272,7 +272,7 @@ export default {
     joinedAtISO() {
       try {
         return new Date(this.profile.createdAt).toISOString();
-      } catch (e) {
+      } catch {
         return '';
       }
     },
@@ -284,7 +284,7 @@ export default {
             month: 'long',
             day: 'numeric',
           });
-      } catch (e) {
+      } catch {
         return '';
       }
     },

diff --git a/src/components/tipRecords/TipRecord.vue b/src/components/tipRecords/TipRecord.vue
@@ -140,12 +140,13 @@ export default {
           title: this.$t('components.tipRecords.TipRecord.claimTitle'),
           body: this.$t('components.tipRecords.TipRecord.claimBodySuccess'),
         });
-      } catch (e) {
+      } catch (error) {
         this.$store.dispatch('modals/open', {
           name: 'failure',
           title: this.$t('components.tipRecords.TipRecord.claimTitle'),
           body: this.$t('components.tipRecords.TipRecord.claimBodyFailure'),
         });
+        console.error(error);
       }
     },
     async pinOrUnPinTip() {

diff --git a/src/utils/index.js b/src/utils/index.js
@@ -31,7 +31,7 @@ export const validateTipUrl = (urlAsString) => {
   try {
     const url = toURL(urlAsString);
     return ['http:', 'https:'].includes(url.protocol) && isFQDN(url.hostname);
-  } catch (e) {
+  } catch {
     return false;
   }
 };

diff --git a/src/views/TipsAndComments.vue b/src/views/TipsAndComments.vue
@@ -120,7 +120,7 @@ export default {
           ? 'backend/reloadComment' : 'backend/reloadTip', this.id || this.tipId);
       } catch (error) {
         this.error = true;
-        throw error;
+        console.error(error);
       } finally {
         this.showLoading = false;
       }