added etcdctl options to resource #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aespinosa can you review please? |
|
can you add unit tests like the ones in https://github.com/aespinosa/cookbook-flannel/tree/master/test/unit? |
| def etcdctl_command | ||
| "#{etcdctl_bin} set #{etcd_prefix} '#{configuration.to_json}'" | ||
| "#{etcdctl_bin}#{etcdctl_opts} set #{etcd_prefix} '#{configuration.to_json}'" |
There was a problem hiding this comment.
does having two spaces when etcdctl_options is nil break the configuration? can lines 81-88 be removed?
There was a problem hiding this comment.
@aespinosa It probably wont break it, if you prefer that i could do it, i thought this was more elegant, but really its just more code?
There was a problem hiding this comment.
yes please. i prefer less code for now.
|
Added tests and addressed my comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an option to add additional options to the etcdctl command when configuring flannel.