Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-651 Update documentation and improve test coverage #212

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

filkeith
Copy link
Contributor

@filkeith filkeith commented Jan 29, 2025

  • reworked readme
  • reworked readers

test coverage will be increased in separate task, when I'll finish adding new functionality.

- adding tests
@reugn reugn changed the title FMWK-651 Update docs and tests FMWK-651 Update documentation and improve test coverage Jan 30, 2025
# Conflicts:
#	cmd/internal/app/validation_test.go
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 37 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (d6bfe30) to head (c7fd452).

Files with missing lines Patch % Lines
io/aws/s3/reader.go 57.69% 8 Missing and 3 partials ⚠️
io/azure/blob/reader.go 61.53% 6 Missing and 4 partials ⚠️
io/gcp/storage/reader.go 61.53% 6 Missing and 4 partials ⚠️
io/local/reader.go 70.58% 3 Missing and 2 partials ⚠️
internal/util/files_sort.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           xdr-support     #212      +/-   ##
===============================================
- Coverage        78.57%   78.54%   -0.04%     
===============================================
  Files              110      110              
  Lines            10079     9941     -138     
===============================================
- Hits              7920     7808     -112     
+ Misses            1661     1635      -26     
  Partials           498      498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filkeith filkeith requested a review from reugn February 4, 2025 12:01
io/aws/s3/reader.go Outdated Show resolved Hide resolved
io/azure/blob/options.go Outdated Show resolved Hide resolved
io/azure/blob/reader.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@filkeith filkeith marked this pull request as ready for review February 4, 2025 13:46
- review fixes
@filkeith filkeith merged commit 06cdf39 into xdr-support Feb 4, 2025
4 checks passed
@filkeith filkeith deleted the FMWK-651-docs-and-tests branch February 4, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants