Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2217] CI/CD: Verify we are linking the wheel with the correct OpenSSL version #700

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Dec 4, 2024

  • Negative testing passes. repair step fails if wrong openssl version is used
  • Repair step passes if correct openssl version is used

TODO

  • Delete branch for negative testing

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2217-cicd-verify-openssl branch from aca5f4e to 2f28030 Compare December 4, 2024 21:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (ca2f4be) to head (2f28030).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #700      +/-   ##
==========================================
+ Coverage   80.89%   81.05%   +0.15%     
==========================================
  Files         102      102              
  Lines       15186    15187       +1     
==========================================
+ Hits        12285    12310      +25     
+ Misses       2901     2877      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review December 4, 2024 21:29
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good

@juliannguyen4 juliannguyen4 merged commit e12a271 into dev Dec 4, 2024
118 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2217-cicd-verify-openssl branch December 4, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants