Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/btcsuite/btcd from 0.0.0-20190824003749-130ea5bddde3 to 0.23.2 #273

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps github.com/btcsuite/btcd from 0.0.0-20190824003749-130ea5bddde3 to 0.23.2.

Release notes

Sourced from github.com/btcsuite/btcd's releases.

btcd v0.23.2

What's Changed

New Contributors

Full Changelog: btcsuite/btcd@v0.23.1...v0.23.2

btcd v0.23.1-beta

What's Changed

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd) from 0.0.0-20190824003749-130ea5bddde3 to 0.23.2.
- [Release notes](https://github.com/btcsuite/btcd/releases)
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES)
- [Commits](https://github.com/btcsuite/btcd/commits/v0.23.2)

---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 2, 2023
@rabbitprincess
Copy link
Member

rabbitprincess commented Oct 12, 2023

btcec is breaking-changed after [email protected], so after bump to 0.23.2, it need to use btcec/v2 instead of btcec.
but it need to change many codes, and also need to update libp2p dependency too. ( libp2p have dependency from btcec. )

@rabbitprincess
Copy link
Member

rabbitprincess commented Oct 12, 2023

We only use secp256k1 logic from btcd. therefore, in my opinion, It may be better to fork only necessary codes rather than update dependencies.

@kroggen
Copy link
Member

kroggen commented Oct 12, 2023

Can aergo use just btcec/v2 instead of btcd?

@kroggen
Copy link
Member

kroggen commented Oct 12, 2023

libp2p is no longer using btcec since this commit

Maybe aergo can use the dcrec/secp256k1/v4 as well

Unless it is too much work to migrate. On this case it can use btcec/v2

@rabbitprincess rabbitprincess mentioned this pull request Oct 30, 2023
5 tasks
@kroggen
Copy link
Member

kroggen commented Oct 31, 2023

The migration from btcd/btcec to dcrec/secp256k1 is implemented here

Copy link
Author

dependabot bot commented on behalf of github May 6, 2024

Superseded by #355.

@dependabot dependabot bot closed this May 6, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/btcsuite/btcd-0.23.2 branch May 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants