Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Talos v1.9.3 #617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Talos v1.9.3 #617

wants to merge 1 commit into from

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Feb 5, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded the core installer and related system images from version v1.9.2 to v1.9.3.
    • Refreshed firmware and driver references for improved consistency across all installation profiles.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 5, 2025
Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

This pull request updates several configuration files by incrementing version numbers and revising image references. The values.yaml file now references the imager image with an updated tag from v1.9.2 to v1.9.3. In addition, multiple YAML files under the installer directory (including initramfs, installer, iso, kernel, metal, and nocloud) update their version fields, base installer image references, and several system extensions’ image references (changing firmware dates from 20241210 to 20250109 and updating drbd and zfs tags). The changes are solely related to configuration versioning.

Changes

File(s) Change Summary
packages/core/builder/values.yaml Updated the imager.image field from ghcr.io/siderolabs/imager:v1.9.2 to ghcr.io/siderolabs/imager:v1.9.3.
packages/core/installer/images/talos/profiles/* (initramfs.yaml, installer.yaml, iso.yaml, kernel.yaml, metal.yaml, nocloud.yaml) Incremented the version field from v1.9.2 to v1.9.3; updated the baseInstaller.imageRef from ghcr.io/siderolabs/installer:v1.9.2 to v1.9.3; revised multiple systemExtensions.imageRef entries (e.g., firmware dates from 20241210 to 20250109 and drbd/zfs tags)

Possibly related PRs

  • cozystack#464: Updates image references and version numbers in configuration files (values.yaml and initramfs.yaml) similarly to these changes.
  • cozystack#570: Updates image versions across various configuration files, including values.yaml.
  • cozystack#553: Focuses on incrementing the version from v1.9.2 to v1.9.3 and updating corresponding image references across multiple installer YAML files.

Suggested labels

enhancement

Suggested reviewers

  • themoriarti

Poem

Hopping through YAML fields so bright,
I found a version hop in sight.
From v1.9.2 to v1.9.3, we gleefully bind,
Images and firmware perfectly aligned.
I’m a little rabbit with a jubilant clack,
Celebrating changes with a happy, hopping track!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 861e6c4 and 34d2978.

📒 Files selected for processing (7)
  • packages/core/builder/values.yaml (1 hunks)
  • packages/core/installer/images/talos/profiles/initramfs.yaml (1 hunks)
  • packages/core/installer/images/talos/profiles/installer.yaml (1 hunks)
  • packages/core/installer/images/talos/profiles/iso.yaml (1 hunks)
  • packages/core/installer/images/talos/profiles/kernel.yaml (1 hunks)
  • packages/core/installer/images/talos/profiles/metal.yaml (1 hunks)
  • packages/core/installer/images/talos/profiles/nocloud.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • packages/core/builder/values.yaml
  • packages/core/installer/images/talos/profiles/metal.yaml
🔇 Additional comments (15)
packages/core/installer/images/talos/profiles/iso.yaml (3)

6-6: Version Field Update Confirmation
The version field has been updated to v1.9.3 as expected. Please ensure that all downstream systems or pipelines referencing this file are aware of the version change.


13-13: BaseInstaller Image Reference Update
The baseInstaller section now correctly points to ghcr.io/siderolabs/installer:v1.9.3. This ensures consistency with the new version release.


15-23: System Extensions Image References Verification
Several image references in the systemExtensions section have been updated:

  • amd-ucode20250109
  • bnx2-bnx2x20250109
  • intel-ice-firmware20250109
  • qlogic-firmware20250109
  • drbd9.2.12-v1.9.3
  • zfs2.2.7-v1.9.3

Please verify that the firmware versions for amdgpu-firmware, i915-ucode, and intel-ucode were intentionally left unchanged (remaining at 20241110/20241112) rather than updated like the others.

packages/core/installer/images/talos/profiles/kernel.yaml (3)

6-6: Version Field Update Confirmation
The version field is now set to v1.9.3, which aligns with the overall upgrade.


13-13: BaseInstaller Image Reference Update
The installer image reference has been updated to ghcr.io/siderolabs/installer:v1.9.3, ensuring the kernel profile uses the correct installer version.


15-23: System Extensions Image References Verification
Updates include:

  • amd-ucode20250109
  • bnx2-bnx2x20250109
  • intel-ice-firmware20250109
  • qlogic-firmware20250109
  • drbd9.2.12-v1.9.3
  • zfs2.2.7-v1.9.3

Again, please confirm that the images for amdgpu-firmware, i915-ucode, and intel-ucode (which remain at 20241110/20241112) are correct and intentionally not updated.

packages/core/installer/images/talos/profiles/installer.yaml (3)

6-6: Installer Profile Version Update
The version field now reflects v1.9.3. This consistent update across profiles helps prevent version mismatches.


13-13: BaseInstaller Image Reference Confirmation
The baseInstaller image reference is updated to ghcr.io/siderolabs/installer:v1.9.3, matching other profile files.


15-23: System Extensions Image Updates Verification
The following changes were made in the systemExtensions block:

  • amd-ucode is now 20250109
  • bnx2-bnx2x is now 20250109
  • intel-ice-firmware is now 20250109
  • qlogic-firmware is now 20250109
  • drbd is updated to 9.2.12-v1.9.3
  • zfs is updated to 2.2.7-v1.9.3

Please double-check that the firmware entries for components like amdgpu-firmware, i915-ucode, and intel-ucode continue to use their previous tags (20241110/20241112) intentionally.

packages/core/installer/images/talos/profiles/initramfs.yaml (3)

6-6: Initramfs Profile Version Update
The profile’s version field is updated to v1.9.3, keeping it in sync with the rest of the profiles.


13-13: BaseInstaller Reference Update in Initramfs
The baseInstaller image reference now correctly uses ghcr.io/siderolabs/installer:v1.9.3.


15-23: System Extensions Updates in Initramfs
Updates include:

  • amd-ucode20250109
  • bnx2-bnx2x20250109
  • intel-ice-firmware20250109
  • qlogic-firmware20250109
  • drbd9.2.12-v1.9.3
  • zfs2.2.7-v1.9.3

Please verify the unchanged firmware versions (amdgpu-firmware, i915-ucode, intel-ucode) are as intended.

packages/core/installer/images/talos/profiles/nocloud.yaml (3)

6-6: Nocloud Profile Version Update
The version field has been updated to v1.9.3. This is in line with the updates in other Talos profiles.


13-13: Updated BaseInstaller Reference
The baseInstaller now points to ghcr.io/siderolabs/installer:v1.9.3, ensuring consistency with the overall release update.


15-23: System Extensions References Consistency Check
The modifications in systemExtensions are as follows:

  • amd-ucode updated to 20250109
  • bnx2-bnx2x updated to 20250109
  • intel-ice-firmware updated to 20250109
  • qlogic-firmware updated to 20250109
  • drbd updated to 9.2.12-v1.9.3
  • zfs updated to 2.2.7-v1.9.3

Again, please ensure that the versions for amdgpu-firmware, i915-ucode, and intel-ucode (which remain unchanged at 20241110/20241112) are intentional.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant