AGS 4.0: implement Overlay.Flip #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-mogilko
added
context: graphics
ags 4
ivan-mogilko
force-pushed
the
ags4--overlayflip
branch
3 times, most recently
from
fc48f5c to
75aea47
Compare
|
Rebased on top of #2620 in sake of convenient testing. Only one final commit belongs to the Overlay.Flip feature. |
ivan-mogilko
force-pushed
the
ags4--overlayflip
branch
from
75aea47 to
0f31bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By user request, this implements Overlay.Flip property that flips overlay graphic in 3 possible ways.
For storage and serialization this uses a new field of type "SpriteTransformationFlags", and a position which was reserved in ags4 save format a while ago. It has flip flags now, but more could be added later as necessary. There's a conversion between script parameter and this new flag set.
NOTE: Software renderer has some bugs in ags4 branch, so switching from some flip to "no flip" does not update the overlay image. I'm planning to address that separately, there's a unfinished code brought by one of the older merges, that was never made to work in completion.