Engine: use safe strcpy function instead of snprintf where truncation expected #2569
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-mogilko
added
the
context: code
ivan-mogilko
force-pushed
the
fix--nonstd-snprintf-truncation
branch
from
14b796d
to
8ab4bc4
Compare
ivan-mogilko
force-pushed
the
fix--nonstd-snprintf-truncation
branch
2 times, most recently
from
a62820e
to
b7fdfe4
Compare
ivan-mogilko
changed the title
ivan-mogilko
force-pushed
the
fix--nonstd-snprintf-truncation
branch
from
b7fdfe4
to
77cfaf4
Compare
ivan-mogilko
changed the title
|
@ericoporto i copied error values and some parts from your Also added asserts to help catch errors. |
ivan-mogilko
force-pushed
the
fix--nonstd-snprintf-truncation
branch
2 times, most recently
from
403f409
to
4c0bbcb
Compare
|
Looks fine, there is a change to |
ivan-mogilko
force-pushed
the
fix--nonstd-snprintf-truncation
branch
from
4c0bbcb
to
2f4345e
Compare
Oops, that was a fix for another warning, it's already in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2567
This replaces uses of
snprintfin the code where truncation of the source string is intended.Added a "ags_strncpy_s", using "strncpy_s" from the C11 extension as a reference (see https://en.cppreference.com/w/c/string/byte/strncpy)