Backport AGS.Native.IScriptCompiler to 3.6.2 #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IScriptCompiler is a compiler interface that lets to address any available compiler. Implementation AGS3ScriptCompiler, which basically wrap calls to the native compiler lib. NOTE: There's already IScriptCompiler in AGS.CScript.Compiler managed library. But it appears to be complicated to use at the moment, because it has number of ties with existing code, including separate message (error) types. I left big TODO comments about merging these interfaces, would someone be willing to improve this situation. This probably will have to be done anyway would Editor work with standalone compilers.
ivan-mogilko
added
what: editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport refactor part from #2552, strictly to sync the code between branches.