Editor: recreate GeneralSettings and DefaultSetup documents when a new game is opened #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to make handlers less reliant on global CurrentGame, and because currently this event may potentially be called before the new CurrentGame is assigned.
This makes GeneralSettings and DefaultSetup panes follow similar rule as other panels that also get recreated on game data refresh, updating from the new CurrentGame reference. In practice this fixes wrong settings displayed after importing an old pre-3.* project.
ivan-mogilko
force-pushed
the
361--fiximportoldproject2
branch
from
61e1362 to
b29c68b
Compare
|
@Crystal-Shard, if you like to test this, the editor build may be got from here: |
|
Yes, that works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1005
This makes GeneralSettings and DefaultSetup behave consistently with the other unique persistent panels (such as GlobalVariables, LipSync, etc), and get recreated when the new game is opened. This fixes them in case CurrentGame reference has changed in the editor.
In practice this fixes editor not acting properly after importing a pre-3.* game.