Fix: don't compress .ags and .vox in android assets
#2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericoporto
force-pushed
the
fix-dont-compress-android
branch
from
3886fb1 to
749f131
Compare
These files require jumping through offsets, to read resources packaged inside them and android decompression is most of what I see when profiling games heavy on assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is made on top of #2214 to make it easy to test. What it does is it specifically disable the additional compression Android does, only for
.agsand.voxpackages.Added some extra things
To-do: check if unpacking an .ags and .vox package in the asset dir makes it run faster - these will still be compressed, but seeking to the file should be faster without the package indirection.