Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme support for Log Panel #2203

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

AlanDrake
Copy link
Contributor

This PR adds theme support to the log panel and fixes a couple things:

  • added default margins to the RichTextBox
  • resized log panel buttons to match icon size

Was there anything new that was missing theming?

- added margins to RichTextBox
- resized log panel buttons to match icon size
@AlanDrake AlanDrake added what: editor related to the game editor context: ui/ux labels Oct 28, 2023
@ivan-mogilko
Copy link
Contributor

Was there anything new that was missing theming?

Looks like the LogPanel's Settings pane is not themed. You make it visible by pressing "Show Settings" toolbar button.

@AlanDrake
Copy link
Contributor Author

AlanDrake commented Oct 31, 2023

It's the propertyGrid (already themed), but I noticed I should also theme the splitter bar.

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Oct 31, 2023

It's the propertyGrid (already themed)

For some reason themes which have "[C]" in their names do not apply colors to the LogPanel's property grid, but do apply colors to the other grids. The themes with "[M]" in the name do apply colors to all of them. Do you know what may be the difference?

@AlanDrake
Copy link
Contributor Author

Do you know what may be the difference?

Not all compat themes have global definitions, but I just finished updating themes, so it shouldn't be a problem.

@ivan-mogilko ivan-mogilko merged commit 313066c into adventuregamestudio:master Oct 31, 2023
20 checks passed
@ivan-mogilko
Copy link
Contributor

Recent themes seem to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: ui/ux what: editor related to the game editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants