Common: avoid if in indexed bmp unpack

[ericoporto]

this is done to squeeze that for to be a little faster when loading something from the spritefile. The change is almost negligible but in the VS Profiler what happens is the fraction of UnpackIndexedBitmap is reduced compared to BitmapToVideoMem (in gfxdriverbase).

[ivan-mogilko]

Actually, copying to a local pal[256] may not even be necessary, because the palette passed into this function is already a local array of 256:

ags/Common/ac/spritefile.cpp

Line 416 in 93c3f7f

uint32_t palette[256];

Perhaps you could remake UnpackIndexedBitmap to accept const std::array<uint32_t, 256> &palette to enforce that.

[ericoporto]

That is a good point, I hadn’t looked up to who was calling it, will adjust to this.

[ericoporto]

Done! After this last change, it lowered relevance from UnpackIndexedBitmap of contributing from 10% to 1.5% to same scene using the VS Profiler! This is huge! (before it only changed from 10% to 8%!)