Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS 4: Completely remove Global Messages and Room Messages #2184

Conversation

ivan-mogilko
Copy link
Contributor

This completely removes any functionality related to deprecated Global Messages and Room Messages from both Editor and Engine.

For built-in GUI dialogs that relied on global messages added small array of hardcoded strings. The downside is that these cannot be translated now. But these dialogs are not suitable for the proper production release anyway.

On a side note, we might eventually require a set of messages for certain engine behavior, that user could provide custom values and possibly translations. For purposes like error and warning reporting. In such case we could recreate functionality, but make these messages have strictly predefined purposes (unlike global msg which could be used freely for custom means).

TODO: fix data format for game data and saves, because they currently contain unused large fixed arrays of ints.

@ivan-mogilko ivan-mogilko added ags 4 related to the ags4 development context: game files related to the files that game uses at runtime context: editor assets related to input files for editing the game context: game logic labels Oct 16, 2023
@ericoporto
Copy link
Member

ericoporto commented Oct 16, 2023

Hey, the failure on CI is because there is a test that in the editor that checks if the room XML is kept, so you would need to adjust that.

edit: it's fixed!

@ivan-mogilko ivan-mogilko force-pushed the ags4--remove-globalroommessages branch from 6d34c2f to 9704374 Compare October 16, 2023 17:00
NOTE: still have to account for their presence in the data file so long as we support older compiled data.
@ivan-mogilko ivan-mogilko force-pushed the ags4--remove-globalroommessages branch from 9704374 to a1418c6 Compare October 18, 2023 16:22
@ivan-mogilko
Copy link
Contributor Author

Had to fix game loading, in case there were still messages found in the old compiled data.

@ericoporto
Copy link
Member

ericoporto commented Oct 18, 2023

Nice, after merging, the APIs cut here can be updated in the checklist in #1810

Edit: erh, actually even though you comment about this in your last message in the thread, the list doesn't include the global message stuff.

@ivan-mogilko ivan-mogilko merged commit 770e429 into adventuregamestudio:ags4 Oct 18, 2023
20 checks passed
@ivan-mogilko ivan-mogilko deleted the ags4--remove-globalroommessages branch October 18, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ags 4 related to the ags4 development context: editor assets related to input files for editing the game context: game files related to the files that game uses at runtime context: game logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants