Add autocomplete tests and backport editor tests #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericoporto
force-pushed
the
add-autocomplete-tests-and-backport-editor-tests
branch
2 times, most recently
from
57924e8 to
cf72527
Compare
ericoporto
force-pushed
the
add-autocomplete-tests-and-backport-editor-tests
branch
7 times, most recently
from
f119be6 to
259df37
Compare
|
@ericoporto I noticed you keep adding the tests, please tell when this is ready to be merged. |
|
This is ready. :) I may make a new PR later that adds a few more tests and do a small refactor in the auto complete parser, but for now I won't have time to look into that, so what is here is what I have for now. |
|
This pr makes unnecessary change to Sprite class reverting its DefaultProperty. |
This is one project for the entire AGS editor source code. It may be desirable to create multiple projects, one test project for each project, but I did it like this for convenience. I also made this using the new csproj format, which may not be compatible with the the currently preferred Visual Studio version. I'll have to rewrite if that is the case Introduces 4 nuget packages: - nunit, the actual testing framework - NUnit3TestAdapter, needed by Visual Studio and later .NET standards to run tests - NSubstitute, the mocking framework - Microsoft.NET.Test.Sdk, needed to run the tests via dotnet CLI
Can be generated by running `$ dotnet test ./Editor/AGS.Editor.Tests/AGS.Editor.Tests.csproj --no-build --no-restore --logger:"junit;LogFilePath=TestResult.xml"` Added missing JUnit import f d
Instead of AGS.Editor. More convenient as we can have tests for AGS.Types in the same project
ericoporto
force-pushed
the
add-autocomplete-tests-and-backport-editor-tests
branch
from
259df37 to
46e5913
Compare
Co-authored-by: Per Olav <[email protected]>
I dropped changes to the Sprite class in 7f20cce ! Yes, that was a mistake, thanks for catching it. |
ericoporto
deleted the
add-autocomplete-tests-and-backport-editor-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1543
I am backporting from ags4 the Editor tests. I didn't pick everything from there, there are some theme related refactors that I skipped and also all the room controller stuff also was skipped. I am more interested in the preprocessor tests.
I really wanted to add a few autocomplete tests, so here they are!