Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deflate algorithm to Sprite Compression using ZLIB-NG #2116

Conversation

ericoporto
Copy link
Member

@ericoporto ericoporto commented Aug 27, 2023

Alternative to #2114, without sources in the repository (fewer line changes) and using zlib-ng instead.

I prefer sources in the repository for small things, zlib-ng is quite huge though, so that's why it's not added - miniz though is small enough it makes more sense to add it.

It's expected that zlib-ng is slightly faster than miniz but the tradeoff is a bigger footprint. I haven't validated this affirmation!!!

@ericoporto ericoporto force-pushed the feature-zlib-compression branch 5 times, most recently from 32ec168 to 9f0f4e5 Compare August 28, 2023 04:24
@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Aug 28, 2023

I'm not sure what to do with this, am I supposed to review and test both #2114 and this? Is there a reason why not use a ready 2114 implementation?

There's also a number of minor things in the new functions that I'd rather fix, because I did not expect to have them in the final variant, but I'd rather wait until one of the PR is merged, because it will be confusing to have these fixes applied in 2+ prs.

@ericoporto
Copy link
Member Author

Sorry, I wasn't sure if you preferred sources in repository or external library, this was more to have alternatives.

I think I prefer the other one with sources in the repository because always there is something wrong in some platform that I need to fix - apparently zlib-ng already has a wrong ifdef for x86 MSVC when the build is static.

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Aug 28, 2023

I do not have a strong preference here, I was going to investigate options, but now since you took over this, then let's use the one that you think is more convenient, so long as it works everywhere.

@ericoporto
Copy link
Member Author

I think I prefer the miniz route then but this is here as a reference if minds are changed.

@ericoporto ericoporto closed this Aug 28, 2023
@ericoporto ericoporto deleted the feature-zlib-compression branch August 31, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants