Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: add support for hardware cursors #2064

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericoporto
Copy link
Member

@ericoporto ericoporto commented Jul 30, 2023

fix #1686

decided to leave it open here just so it's easier to find. There are design issues to solve and this will also probably actually be in ags4 branch - but for testing ideas, I find it easier to work in master, so while it's draft may be better to work in this way. (I will probably finish the iOS PR that is open for too long before working more on this though)

currently for whatever reason this doesn't work in real fullscreen (at least on Windows), this worked in the past so it may just be something dumb in the way the code is done.

@ericoporto
Copy link
Member Author

ericoporto commented Feb 18, 2024

for some reason using alt+enter is crashing any game now with an Error: failed to restore graphics mode message. Edit: uhm, it appears only when using DirectX driver, it works fine when using OpenGL.

@ivan-mogilko
Copy link
Contributor

for some reason using alt+enter is crashing any game now with an Error: failed to restore graphics mode message. Edit: uhm, it appears only when using DirectX driver, it works fine when using OpenGL.

This happens in master branch after aa0647d, which was a part of #2223.
Might be some resource is not released before resetting device. I will look into this.

@ivan-mogilko
Copy link
Contributor

Okay, the D3D reset should be fixed: 5994b90

@ericoporto ericoporto force-pushed the feature-hardware-cursor branch from fdcaf31 to bb31e32 Compare February 18, 2024 19:14
@ericoporto
Copy link
Member Author

Okay, the D3D reset should be fixed: 5994b90

Thanks! This indeed fixed the error!

@ericoporto ericoporto force-pushed the feature-hardware-cursor branch from bb31e32 to 7cf9cd2 Compare March 3, 2024 23:02
@ericoporto ericoporto force-pushed the feature-hardware-cursor branch 5 times, most recently from edf6735 to 1e63b33 Compare September 1, 2024 01:37
@ericoporto ericoporto force-pushed the feature-hardware-cursor branch from 1e63b33 to f8ae9c4 Compare September 13, 2024 23:58
@ericoporto ericoporto force-pushed the feature-hardware-cursor branch from f8ae9c4 to 2063858 Compare September 13, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support directly using Operating System (hardware) cursors
2 participants