Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename XSJS packs to remove -async- qualifier #160

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

lcartey
Copy link
Contributor

@lcartey lcartey commented Nov 20, 2024

XSJS comes in multiple flavours:

  • XS Classic - these applications run on an embedded runtime which provides a native library for application development.
  • XS Advanced - these applications run on a Node.js based runtime, and use a library dependency to provide essentially the same API as used by XS Classic applications. This library comes in two forms, @sap/xsjs and @sap/xsjs-async, with the primary difference being whether the library requires the use of async/await.

Our existing modelling supports all flavours, so we we can rename the QL packs to remove the -async- qualifier, which would otherwise indicate that we only support the @sap/xsjs-async library.

We support the non-async versions of XSJS, so rename the packs for
clarity.
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jeongsoolee09 jeongsoolee09 merged commit e715c35 into main Nov 20, 2024
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the lcartey/rename-xsjs-packs branch November 20, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants