Refine locations in the CDS file #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exclude objects without a $locations property - Use the known name to deduce the end column
CdlAttributes extend CdlObject, not CdlElement, but still require location sniffing.
* Use the file location only if no line/col data * Use the col start line if available, otherwise choose col 0 * Use the end line deduction if available, otherwise use 1 past the start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our locations in CDS files by:
.cds.jsonfile for CDL definitions which do not directly appear in the.cdsfile. These are usually metadata elements in the.cds.json, used for grouping data produced by the compiler.