-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ifelse
#94
Support ifelse
#94
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 79.63% 80.58% +0.94%
==========================================
Files 17 18 +1
Lines 712 757 +45
==========================================
+ Hits 567 610 +43
- Misses 145 147 +2 ☔ View full report in Codecov by Sentry. |
some of which now pass
The test failures you're seeing here are an example of comparison method ambiguities #95 (comment) |
Very odd and generic error on 1.6. Can
L3 is: function Base.ifelse(::T, x, y) where {T<:SimpleTracer}
size(x) != size(y) &&
throw(DimensionMismatch("Outputs sizes of `ifelse` arguments don't match in size."))
return output_union(x, y)
end |
No clue, never encountered this |
Quick prototype to discuss #90.Tests pass on 1.10, I'll fix 1.6 in case this is useful.Major changes:
Dual
is now aReal
, not anAbstractTracer
ifelse
onAbstractTracer