Handle load errors when config is not initialized #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigtiger
force-pushed
the
issues-20-error-on-initial-load
branch
from
8818f30 to
8fb912c
Compare
| .map(function(i) { return i.trim(); }); | ||
| let css = generate_column_hiding_css(column_collection); | ||
| window.v1_column_hiding_style_el = add_css_to_document(css); | ||
| if (typeof items.columnsToHide != 'undefined') { |
There was a problem hiding this comment.
If my understanding of chrome's storage API is correct, the { 'columnsToHide': '' } bit should ensure that items.columnsToHide is always defined inside the callback function (either as whatever was stored or as the fallback default of empty string), so I don't think the undefined check is needed here.
There was a problem hiding this comment.
@BaseCase Agreed. Reverted those changes.
Also, you should try the version on the Chrome Web Store: https://chrome.google.com/webstore/detail/versionone-shot/ifljgacfkdomobnaeibimidndmblihoh
added 2 commits
May 14, 2016 11:12
|
Assuming 👍 from Casey's feedback. |
|
retroactive 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20