Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files required to consistently build Alpine APKs for January Release #1119

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

steelhead31
Copy link
Contributor

Add the usual APKs so that the previous method of building the APK files works, also pin the alpine builds to docker latest.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@smlambert
Copy link
Contributor

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@smlambert
Copy link
Contributor

/approve

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the removal of the / in:

def fullURL = "${baseURL}/${binaryRepo}"

is safe than I'm good with this - as far as I can tell there's nothing otherwise risky here

@sxa
Copy link
Member

sxa commented Jan 29, 2025

/approve

@github-actions github-actions bot dismissed their stale review January 29, 2025 17:32

Thank you @smlambert and @sxa for your approvals, this pull request is now approved to merge during release.

@steelhead31 steelhead31 merged commit 5ca028d into adoptium:master Jan 29, 2025
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants