Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix : Update automated installer production to validate architecture per distro #1107

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Jan 23, 2025

A bug was spotted during the release cycle, whereby it was incorrectly trying to determine which alpine node to build on for a non alpine package build.

This bug fix amends the node identification to be based on the type of packages ( alpine / or non alpine ) being built.

Part of #1005

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has the fix for the "Skipped parameter" warnings from adoptium/infrastructure#2774 (comment) too :-)

@steelhead31
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@gdams
Copy link
Member

gdams commented Jan 23, 2025

/approve

2 similar comments
@andrew-m-leonard
Copy link
Contributor

/approve

@tellison
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review January 23, 2025 12:47

Thank you @gdams and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.

@steelhead31 steelhead31 merged commit 4aa7c98 into adoptium:master Jan 23, 2025
6 checks passed
@steelhead31 steelhead31 self-assigned this Jan 23, 2025
@steelhead31 steelhead31 deleted the linux_pkg_handle_params branch January 27, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants