Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu16.04 build dockerfile #2201

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 2, 2021

Create and Ubuntu16.04 dockerfile similar to the CentOS6/7 ones so that we can continue to run these on a more secure host for the arm32 JDK8/11 builds which we currently build on Ubuntu 16.04

Approvals welcome but PLEASE LEAVE FOR ME TO MERGE ONCE i'M FULLY HAPPY WITH IT.

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

NOTES:

  • It looks like openjdk-7-jdk can no longer be located so I have removed that and set JDK7_BOOT_DIR to point to openjdk-8. It may have been removed from http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/pool/main/o/openjdk-7/ for armhd at some point. I have a tarred up version of the openjdk-7-jdk directory from one of the current build machines so potentially it could be deployed if we decide that using JDK8 to bootstrap JDK8 is not desirable going forward.
  • If we're going to put this into prodution we'll need a way to generate and distribute the image to the build systems, but putting this dockerfile in place is a first step.
  • A static copy of an image created form these changes has been created with SHA256 checksum 31ddb40b03588fe36b08202bc41beaa2d4086094871d48eb641e9835e170529a (recording that for my own benefit as I have not published it anywhere)
  • The uname stuff is a bit of a hack but without it the main build completes but make images fails when running on a 64-bit host.

@sxa sxa self-assigned this Jun 2, 2021
@sxa sxa changed the title Ubuntu1604 build dockerfile Add Ubuntu16.04 build dockerfile Jun 2, 2021
@sxa sxa marked this pull request as draft June 2, 2021 15:23
@sxa sxa force-pushed the ubuntu1604-build-dockerfile branch 2 times, most recently from 348049a to 5754f0e Compare June 3, 2021 10:36
@sxa sxa marked this pull request as ready for review June 3, 2021 12:25
@sxa sxa marked this pull request as draft June 3, 2021 15:07
@karianna karianna added this to the June 2021 milestone Jun 6, 2021
@karianna karianna linked an issue Jun 6, 2021 that may be closed by this pull request
@sxa sxa force-pushed the ubuntu1604-build-dockerfile branch 2 times, most recently from 923074f to aa9abbd Compare June 11, 2021 11:07
@sxa sxa marked this pull request as ready for review June 11, 2021 11:12
@sxa
Copy link
Member Author

sxa commented Jun 11, 2021

Ansible Lint failure appears unrelated to this PR but will need to be investigated

@sxa sxa force-pushed the ubuntu1604-build-dockerfile branch 3 times, most recently from e897e31 to fbbe0f4 Compare June 11, 2021 15:17
@github-actions github-actions bot added docker and removed docker labels Jun 14, 2021
@sxa sxa force-pushed the ubuntu1604-build-dockerfile branch from 5589c1d to 427557a Compare June 15, 2021 12:51
@github-actions github-actions bot added docker and removed docker labels Jun 15, 2021
@sxa sxa force-pushed the ubuntu1604-build-dockerfile branch from 427557a to 4371772 Compare June 15, 2021 13:31
@github-actions github-actions bot removed the docker label Jun 15, 2021
@sxa sxa force-pushed the ubuntu1604-build-dockerfile branch 2 times, most recently from d9a82c4 to decf0ff Compare June 15, 2021 21:43
@gdams
Copy link
Member

gdams commented Jun 16, 2021

@sxa I pushed up the jenkinsfile changes in order to build and push this dockerfile

@sxa
Copy link
Member Author

sxa commented Jun 16, 2021

@sxa I pushed up the jenkinsfile changes in order to build and push this dockerfile

If I'm reading this right you've done it for aarch64. This is being done as a requirement for armv7l which we are currently building on Ubuntu 16.04 - we should not require this build for architectures other than armv7l unless there's a different use case that you're thinking of.

@gdams
Copy link
Member

gdams commented Jun 16, 2021

I added a build for x64 just because it would be strange to only build an arm64 image but didn't add ppc64le

@sxa
Copy link
Member Author

sxa commented Jun 16, 2021

I added a build for x64 just because it would be strange to only build an arm64 image but didn't add ppc64le

But we only need it for arm32, not arm64 :-)

@gdams
Copy link
Member

gdams commented Jun 16, 2021

Haha my bad, I'll update the jenkinsfile later

@gdams
Copy link
Member

gdams commented Jun 16, 2021

okay @sxa that should be good now

@gdams gdams force-pushed the ubuntu1604-build-dockerfile branch from 3846caa to 45f383f Compare June 16, 2021 23:19
@sxa
Copy link
Member Author

sxa commented Jun 16, 2021

Thanks. I'm going to hold off on merging for now due to another issue with the compiler that we need to think about ... (I may just think about it, procrastinate for a bit, merge it anyway, then find a better solution later)
Ref: adoptium/adoptium-support#319

sxa added 2 commits June 17, 2021 19:56
…dk-infrastructure into ubuntu1604-build-dockerfile
Signed-off-by: Stewart X Addison <[email protected]>
@sxa
Copy link
Member Author

sxa commented Jun 18, 2021

Solaris failure does not seem related to this PR therefore merging. Have raised #2226 to investigate.
This has now been deployed for:

For reference. JDK17/arm32 on the Altra takes about 11 minutes to perform the build phase, and 7 minutes with a populated ccache.

@sxa sxa merged commit 147d90e into adoptium:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decommission scaleway arm32 systems
3 participants