Fix/issue 794 review code of returned data #813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was looking at the code to understand this issue #794, I decided to use this time to improve some pieces of code. Let me know if it was a good idea or not 😄
I have moved up all failures and exceptions at API level in *Resource.kt. (e.g NotFoundException or BadRequestException caused by invalid VersionRangeFilter)
I have moved down ReleaseFilter, BinaryFilter, Order and Sort manipulations into *Endpoint.kt level.
I have done those changes to centralize calls to getAdoptRepos() and getFilteredReleases() and to avoid mistakes in the futur. I have also tried to improve the readability.
Checklist
mvn clean installbuild and test completes