Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix temurin version, arch and OSname display bug #731

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented Jan 27, 2025

Description of change

Seems there was breaking change in the Trans component. That's how best I can think of it
closes #709

<Trans
  i18nKey="myKey" // optional -> fallbacks to defaults if not provided
  defaults="hello <italic>beautiful</italic> <bold>{{what}}</bold>" // optional defaultValue
  values={{ what: 'world'}}
  components={{ italic: <i />, bold: <strong /> }}
/>

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Screeenshots

Screenshot 2025-01-27 at 08 50 02

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for adoptium-rewrite ready!

Name Link
🔨 Latest commit 11fe895
🔍 Latest deploy log https://app.netlify.com/sites/adoptium-rewrite/deploys/67971ea9923ee00008bfcaad
😎 Deploy Preview https://deploy-preview-731--adoptium-rewrite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jexsie
Copy link
Contributor Author

Jexsie commented Jan 27, 2025

cc @gdams

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (0b8a546) to head (11fe895).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   82.36%   82.36%   -0.01%     
==========================================
  Files         145      145              
  Lines       10782    10780       -2     
  Branches      829      829              
==========================================
- Hits         8881     8879       -2     
  Misses       1901     1901              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdams gdams merged commit b9b211a into adoptium:main Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage fix Download Temurin [object Object] for [object Object] [object Object]
2 participants