Migrate to PNPM #552
Migrate to PNPM #552
Conversation
|
Ember 5.12 scenario started to fail again due to
This should have been fixed in #547. We have the package as a peer dependency and a dev dependency. I have no idea why migrating to PNPM breaks it to be honest. |
package.json
Outdated
| @@ -49,14 +49,15 @@ | |||
| }, | |||
| "dependencies": { | |||
| "broccoli-funnel": "^3.0.2", | |||
| "ember-auto-import": "^2.6.3", | |||
There was a problem hiding this comment.
I moved this breaking change out to #553 which should be merged first.
| "@ember/string": "^3.0.1", | ||
| "@ember/string": "^4.0.0", |
There was a problem hiding this comment.
This fixes an issue introduced in #547. The project had a direct dependency on ^3.0.1 of @ember/string but a resolution forcing all transitive dependencies to resolve to ^4.0.0. Please let me know if you prefer this to be pulled out to a separate PR.
| @@ -19,17 +19,20 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: pnpm/action-setup@v2 | |||
| with: | |||
| version: 8 | |||
There was a problem hiding this comment.
@jelhan out of curiosity, why not using pnpm v9 right away?
There was a problem hiding this comment.
I followed the setup of the latest Ember CLI blueprints: https://github.com/ember-cli/ember-cli/blob/6691ea1008dd734a9c18c0ec5ed7a389987f608b/blueprints/addon/files/.github/workflows/ci.yml#L22-L24
Migrates the project from yarn v1 to PNPM. PNPM is the recommended package manager for the adopted-ember-addons org per adopted-ember-addons/program-guidelines#28.