Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix(Toast): resume timers if no longer over toast region after a toast is removed #7681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: fix(Toast): resume timers if no longer over toast region after a toast is removed #7681

wants to merge 1 commit into from
+49 −2

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Jan 28, 2025 •
edited
Loading

Edit: Debugging why this doesn't work on the built version but works locally

Closes #7024

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. In the Toast story with a timeout enabled, open two toasts
  2. Close the top one and keep your mouse where it is

The remaining toast should close after a few seconds due to the timeout. Previously it would not due to the timer not resuming, due to no pointerleave event being fired in this case.

🧢 Your Project:

@reidbarber reidbarber changed the title fix(Toast): check pointer position and resume toast timers if no longer over region fix(Toast): resume timers if no longer over toast region after a toast is removed Jan 28, 2025
@rspbot
Copy link

rspbot commented Jan 28, 2025

Build successful! 🎉

@reidbarber reidbarber changed the title fix(Toast): resume timers if no longer over toast region after a toast is removed WIP: fix(Toast): resume timers if no longer over toast region after a toast is removed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple auto-dismiss toasts
2 participants
@reidbarber @rspbot