Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries on multi-platform image builds #71

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

shanejbrown
Copy link
Contributor

@shanejbrown shanejbrown commented Sep 7, 2023

Description

An intermittent MP build failure occurs on build nodes. With a docker exception and error message similar to these:

16:07:27 #19 ERROR: Get "http://localhost:33321/v2/": read tcp [::1]:35204->[::1]:33321: read: connection reset by peer
16:07:27 ------
16:07:27 > pushing localhost:33321/buildrunner-mp-containerize-pr-125-265.i0fac61.m0-1-linux-arm64-v8:latest with docker:
16:07:27 ------
16:07:27 ERROR: Get "http://localhost:33321/v2/": read tcp [::1]:35204->[::1]:33321: read: connection reset by peer

This occurs on building MP images. And when retrying the build it does eventually successfully build. This is a quick fix until a deeper investigation can be completed.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shanejbrown shanejbrown marked this pull request as ready for review September 7, 2023 20:07
@@ -212,6 +213,7 @@ def _stop_local_registry(self):
LOGGER.warning("Local registry is not running when attempting to stop it")

# pylint: disable=too-many-arguments
@retry(python_on_whales.exceptions.DockerException, tries=5, delay=1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit high to me, but it'll work for now

@shanejbrown shanejbrown merged commit bc91f34 into adobe:main Sep 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants