Replace ';' with '&&' in Dockerfile #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
approved these changes
Sep 1, 2023
bluesliverx
reviewed
Sep 1, 2023
Dockerfile
Outdated
| set -ex; \ | ||
| useradd -m buildrunner; \ | ||
| apt update; \ | ||
| set -ex && \ |
There was a problem hiding this comment.
Remove this line then, since it does what the && is effectively doing.
There was a problem hiding this comment.
Or at least the -e portion, so it's set -x
bluesliverx
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing semi-colons with && in the Dockerfile ensures that if any of the commands fail then the Docker build will fail.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: