Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to published docker image #52

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

shanejbrown
Copy link
Contributor

@shanejbrown shanejbrown commented Jul 26, 2023

Description

Add version to the published docker image in github

Related Issue

Motivation and Context

The images are all tagged as latest which makes reverting to previous working versions of the image difficult.

How Has This Been Tested?

Setup a different branch on my forked repo and tested out very similar code to this PR, although not exact since the .git/workflows/build.yaml specifically calls out the adobe/main repo and branch.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shanejbrown shanejbrown marked this pull request as ready for review July 27, 2023 16:14
@shanejbrown shanejbrown merged commit 4b64d86 into adobe:main Jul 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants