Only pull docker daemon proxy image in tests #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejbrown
commented
Aug 21, 2024
tests/test_runner.py
Outdated
| @@ -1,3 +1,5 @@ | |||
| from buildrunner.docker.daemon import DAEMON_IMAGE_NAME | |||
| from buildrunner import docker as buildrunner_docker | |||
There was a problem hiding this comment.
The ordering of these imports seems strange to me. But Ruff forced me to put these at the top.
There was a problem hiding this comment.
Uhh, that's definitely wrong, why would ruff tell you that?
There was a problem hiding this comment.
# noqa: E402 to the rescue.
bluesliverx
approved these changes
Aug 21, 2024
shanejbrown
commented
Aug 21, 2024
| import os | ||
| import sys | ||
| import docker.errors | ||
|
|
||
| sys.path.insert(0, os.path.realpath(os.path.join(os.path.dirname(__file__), ".."))) | ||
|
|
||
| import buildrunner.config.loader # noqa: E402 | ||
| from buildrunner.docker.daemon import DAEMON_IMAGE_NAME # noqa: E402 | ||
| from buildrunner import docker as buildrunner_docker # noqa: E402 |
There was a problem hiding this comment.
Fixed with # noqa: E402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).