Add buildx builder support to get_ssh_agent_image #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
reviewed
Aug 19, 2024
buildrunner/sshagent/__init__.py
Outdated
| use_threading=False, | ||
| ) | ||
| ) | ||
| assert len(built_images_info.built_images) == 1 |
There was a problem hiding this comment.
Maybe this assertion should have an error message describing what to do if it fails (i.e. retry?)
There was a problem hiding this comment.
Honestly I prefer using an if ... raise pattern here instead of assertion since the assertion pretty much always throws a bad stacktrace and can be difficult to read.
There was a problem hiding this comment.
Yeah, that makes sense. I can update that.
|
I should have had this on a branch other than main. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).