Add cache_from and cache_to support for multiplatform builds #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
reviewed
Jun 12, 2024
bluesliverx
reviewed
Jun 12, 2024
bluesliverx
reviewed
Jun 12, 2024
bluesliverx
reviewed
Jun 12, 2024
bluesliverx
reviewed
Jun 12, 2024
bluesliverx
reviewed
Jun 12, 2024
bluesliverx
reviewed
Jun 12, 2024
| self.step_runner.log.write( | ||
| f"WARNING: Unable to pull the cache_from image: {cache_from_image}\n" | ||
| ) | ||
| if isinstance(cache_from_image, str): |
There was a problem hiding this comment.
Oh, this is in the single platform code, gotcha.
There was a problem hiding this comment.
I could change it to support multiplatform and it should be beneficial for our build nodes.
There was a problem hiding this comment.
I'll create a new ticket to track this, so we can test it too.
bluesliverx
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache_from and cache_to support for multiplatform builds. Passes cache_from and cache_to arguments to python_on_whales.
What does this PR do?
Improve multiplatform support.
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).